drm/amd/powerplay: Fix missing break in switch

GustavoARSilva · alexdeucher · commit 2f10d8237396 · 2019-01-29T10:57:02.000-05:00
Add missing break statement in order to prevent the code from falling through to the default case. The resoning for this is that pclk_vol_table is an automatic variable. So, it makes no sense to update it just before falling through to the default case and return -EINVAL. This bug was found thanks to the ongoing efforts to enabling -Wimplicit-fallthrough. Fixes: cd70f3d ("drm/amd/powerplay: PP/DAL interface changes for dynamic clock switch") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
@@ -1033,6 +1033,7 @@ static int smu10_get_clock_by_type_with_latency(struct pp_hwmgr *hwmgr,
 		break;
 	case amd_pp_dpp_clock:
 		pclk_vol_table = pinfo->vdd_dep_on_dppclk;
+		break;
 	default:
 		return -EINVAL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1033,6 +1033,7 @@ static int smu10_get_clock_by_type_with_latency(struct pp_hwmgr *hwmgr,`
`1033`	`1033`	`break;`
`1034`	`1034`	`case amd_pp_dpp_clock:`
`1035`	`1035`	`pclk_vol_table = pinfo->vdd_dep_on_dppclk;`
	`1036`	`+ break;`
`1036`	`1037`	`default:`
`1037`	`1038`	`return -EINVAL;`
`1038`	`1039`	`}`