Skip to content

Commit 2fffad1

Browse files
committed
Merge tag 'mmc-v4.6-rc3' of git://git.linaro.org/people/ulf.hansson/mmc
Pull MMC fixes from Ulf Hansson: "Here are a couple of mmc fixes intended for v4.6 rc4. Regarding the fix for the regression about mmcblk device indexes. The approach taken to solve the problem seems to be good enough. There were some discussions around the solution, but it seems like people were happy about it in the end. MMC core: - Restore similar old behaviour when assigning mmcblk device indexes MMC host: - tegra: Disable UHS-I modes for Tegra124 to fix regression" * tag 'mmc-v4.6-rc3' of git://git.linaro.org/people/ulf.hansson/mmc: mmc: tegra: Disable UHS-I modes for Tegra124 mmc: block: Use the mmc host device index as the mmcblk device index
2 parents ab5f9eb + 70ad7f7 commit 2fffad1

File tree

2 files changed

+2
-26
lines changed

2 files changed

+2
-26
lines changed

drivers/mmc/card/block.c

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ static int max_devices;
8686

8787
/* TODO: Replace these with struct ida */
8888
static DECLARE_BITMAP(dev_use, MAX_DEVICES);
89-
static DECLARE_BITMAP(name_use, MAX_DEVICES);
9089

9190
/*
9291
* There is one mmc_blk_data per slot.
@@ -105,7 +104,6 @@ struct mmc_blk_data {
105104
unsigned int usage;
106105
unsigned int read_only;
107106
unsigned int part_type;
108-
unsigned int name_idx;
109107
unsigned int reset_done;
110108
#define MMC_BLK_READ BIT(0)
111109
#define MMC_BLK_WRITE BIT(1)
@@ -2202,19 +2200,6 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
22022200
goto out;
22032201
}
22042202

2205-
/*
2206-
* !subname implies we are creating main mmc_blk_data that will be
2207-
* associated with mmc_card with dev_set_drvdata. Due to device
2208-
* partitions, devidx will not coincide with a per-physical card
2209-
* index anymore so we keep track of a name index.
2210-
*/
2211-
if (!subname) {
2212-
md->name_idx = find_first_zero_bit(name_use, max_devices);
2213-
__set_bit(md->name_idx, name_use);
2214-
} else
2215-
md->name_idx = ((struct mmc_blk_data *)
2216-
dev_to_disk(parent)->private_data)->name_idx;
2217-
22182203
md->area_type = area_type;
22192204

22202205
/*
@@ -2264,7 +2249,7 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
22642249
*/
22652250

22662251
snprintf(md->disk->disk_name, sizeof(md->disk->disk_name),
2267-
"mmcblk%u%s", md->name_idx, subname ? subname : "");
2252+
"mmcblk%u%s", card->host->index, subname ? subname : "");
22682253

22692254
if (mmc_card_mmc(card))
22702255
blk_queue_logical_block_size(md->queue.queue,
@@ -2418,7 +2403,6 @@ static void mmc_blk_remove_parts(struct mmc_card *card,
24182403
struct list_head *pos, *q;
24192404
struct mmc_blk_data *part_md;
24202405

2421-
__clear_bit(md->name_idx, name_use);
24222406
list_for_each_safe(pos, q, &md->part) {
24232407
part_md = list_entry(pos, struct mmc_blk_data, part);
24242408
list_del(pos);

drivers/mmc/host/sdhci-tegra.c

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -382,14 +382,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra114 = {
382382
.pdata = &sdhci_tegra114_pdata,
383383
};
384384

385-
static const struct sdhci_tegra_soc_data soc_data_tegra124 = {
386-
.pdata = &sdhci_tegra114_pdata,
387-
.nvquirks = NVQUIRK_ENABLE_SDR50 |
388-
NVQUIRK_ENABLE_DDR50 |
389-
NVQUIRK_ENABLE_SDR104 |
390-
NVQUIRK_HAS_PADCALIB,
391-
};
392-
393385
static const struct sdhci_pltfm_data sdhci_tegra210_pdata = {
394386
.quirks = SDHCI_QUIRK_BROKEN_TIMEOUT_VAL |
395387
SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
@@ -407,7 +399,7 @@ static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
407399

408400
static const struct of_device_id sdhci_tegra_dt_match[] = {
409401
{ .compatible = "nvidia,tegra210-sdhci", .data = &soc_data_tegra210 },
410-
{ .compatible = "nvidia,tegra124-sdhci", .data = &soc_data_tegra124 },
402+
{ .compatible = "nvidia,tegra124-sdhci", .data = &soc_data_tegra114 },
411403
{ .compatible = "nvidia,tegra114-sdhci", .data = &soc_data_tegra114 },
412404
{ .compatible = "nvidia,tegra30-sdhci", .data = &soc_data_tegra30 },
413405
{ .compatible = "nvidia,tegra20-sdhci", .data = &soc_data_tegra20 },

0 commit comments

Comments
 (0)