powerpc/PCI: Add struct pci_ops member names to initialization

robherring · bjorn-helgaas · commit 453c02c28405 · 2015-01-22T13:58:43.000-06:00
Some instances of pci_ops initialization rely on the read/write members'
location in the struct.  This is fragile and may break when adding new
members to the beginning of the struct.

No functional change.

Signed-off-by: Rob Herring &lt;robh@kernel.org&gt;
Signed-off-by: Bjorn Helgaas &lt;bhelgaas@google.com&gt;
CC: Arnd Bergmann &lt;arnd@arndb.de&gt;
CC: Benjamin Herrenschmidt &lt;benh@kernel.crashing.org&gt;
CC: Paul Mackerras &lt;paulus@samba.org&gt;
CC: Michael Ellerman &lt;mpe@ellerman.id.au&gt;
CC: linuxppc-dev@lists.ozlabs.org
CC: cbe-oss-dev@lists.ozlabs.org
diff --git a/arch/powerpc/platforms/cell/celleb_scc_pciex.c b/arch/powerpc/platforms/cell/celleb_scc_pciex.c
@@ -399,8 +399,8 @@ static int scc_pciex_write_config(struct pci_bus *bus, unsigned int devfn,
 }
 
 static struct pci_ops scc_pciex_pci_ops = {
-	scc_pciex_read_config,
-	scc_pciex_write_config,
+	.read = scc_pciex_read_config,
+	.write = scc_pciex_write_config,
 };
 
 static void pciex_clear_intr_all(unsigned int __iomem *base)

Original file line number	Diff line number	Diff line change
`@@ -399,8 +399,8 @@ static int scc_pciex_write_config(struct pci_bus *bus, unsigned int devfn,`
`399`	`399`	`}`
`400`	`400`
`401`	`401`	`static struct pci_ops scc_pciex_pci_ops = {`
`402`		`- scc_pciex_read_config,`
`403`		`- scc_pciex_write_config,`
	`402`	`+ .read = scc_pciex_read_config,`
	`403`	`+ .write = scc_pciex_write_config,`
`404`	`404`	`};`
`405`	`405`
`406`	`406`	`static void pciex_clear_intr_all(unsigned int __iomem *base)`