xen/pci: Bubble up error and fix description.

konradwilk · jgross1 · commit 577f79e411b7 · 2016-12-08T07:54:04.000+01:00
The function is never called under PV guests, and only shows up
when MSI (or MSI-X) cannot be allocated. Convert the message
to include the error value.

Signed-off-by: Konrad Rzeszutek Wilk &lt;konrad.wilk@oracle.com&gt;
Reviewed-by: Juergen Gross &lt;jgross@suse.com&gt;
Signed-off-by: Juergen Gross &lt;jgross@suse.com&gt;
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
@@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
 	return 0;
 
 error:
-	dev_err(&dev->dev,
-		"Xen PCI frontend has not registered MSI/MSI-X support!\n");
+	dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n",
+		type == PCI_CAP_ID_MSI ? "" : "-X", irq);
 	return irq;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)`
`264`	`264`	`return 0;`
`265`	`265`
`266`	`266`	`error:`
`267`		`- dev_err(&dev->dev,`
`268`		`- "Xen PCI frontend has not registered MSI/MSI-X support!\n");`
	`267`	`+ dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n",`
	`268`	`+ type == PCI_CAP_ID_MSI ? "" : "-X", irq);`
`269`	`269`	`return irq;`
`270`	`270`	`}`
`271`	`271`