IB/rxe: Don't check for null ptr in send()

Andrew Boyer · dledford · commit 5cc8fabc5e4c · 2016-12-22T11:36:12.000-05:00
pkt-&gt;qp was already dereferenced earlier in the function.

Fixes Smatch complaint:
drivers/infiniband/sw/rxe/rxe_net.c:458 send()
	 warn: variable dereferenced before check 'pkt-&gt;qp' (see line 441)

Signed-off-by: Andrew Boyer &lt;andrew.boyer@dell.com&gt;
Signed-off-by: Doug Ledford &lt;dledford@redhat.com&gt;
diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -459,8 +459,7 @@ static int send(struct rxe_dev *rxe, struct rxe_pkt_info *pkt,
 		return -EAGAIN;
 	}
 
-	if (pkt->qp)
-		atomic_inc(&pkt->qp->skb_out);
+	atomic_inc(&pkt->qp->skb_out);
 	kfree_skb(skb);
 
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -459,8 +459,7 @@ static int send(struct rxe_dev rxe, struct rxe_pkt_info pkt,`
`459`	`459`	`return -EAGAIN;`
`460`	`460`	`}`
`461`	`461`
`462`		`- if (pkt->qp)`
`463`		`- atomic_inc(&pkt->qp->skb_out);`
	`462`	`+ atomic_inc(&pkt->qp->skb_out);`
`464`	`463`	`kfree_skb(skb);`
`465`	`464`
`466`	`465`	`return 0;`