Skip to content

Commit 7a50e46

Browse files
haukeralfbaechle
authored andcommitted
MIPS: Fix build error when SMP is used without GIC
The MIPS_GIC_IPI should only be selected when MIPS_GIC is also selected, otherwise it results in a compile error. smp-gic.c uses some functions from include/linux/irqchip/mips-gic.h like plat_ipi_call_int_xlate() which are only added to the header file when MIPS_GIC is set. The Lantiq SoC does not use the GIC, but supports SMP. The calls top the functions from smp-gic.c are already protected by some #ifdefs The first part of this was introduced in commit 72e2014 ("MIPS: Move GIC IPI functions out of smp-cmp.c") Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> Cc: Paul Burton <paul.burton@imgtec.com> Cc: stable@vger.kernel.org # v3.15+ Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/12774/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
1 parent 4b7b1ef commit 7a50e46

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

arch/mips/Kconfig

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2169,7 +2169,7 @@ config MIPS_MT_SMP
21692169
select CPU_MIPSR2_IRQ_VI
21702170
select CPU_MIPSR2_IRQ_EI
21712171
select SYNC_R4K
2172-
select MIPS_GIC_IPI
2172+
select MIPS_GIC_IPI if MIPS_GIC
21732173
select MIPS_MT
21742174
select SMP
21752175
select SMP_UP
@@ -2267,7 +2267,7 @@ config MIPS_VPE_APSP_API_MT
22672267
config MIPS_CMP
22682268
bool "MIPS CMP framework support (DEPRECATED)"
22692269
depends on SYS_SUPPORTS_MIPS_CMP && !CPU_MIPSR6
2270-
select MIPS_GIC_IPI
2270+
select MIPS_GIC_IPI if MIPS_GIC
22712271
select SMP
22722272
select SYNC_R4K
22732273
select SYS_SUPPORTS_SMP
@@ -2287,7 +2287,7 @@ config MIPS_CPS
22872287
select MIPS_CM
22882288
select MIPS_CPC
22892289
select MIPS_CPS_PM if HOTPLUG_CPU
2290-
select MIPS_GIC_IPI
2290+
select MIPS_GIC_IPI if MIPS_GIC
22912291
select SMP
22922292
select SYNC_R4K if (CEVT_R4K || CSRC_R4K)
22932293
select SYS_SUPPORTS_HOTPLUG_CPU
@@ -2306,6 +2306,7 @@ config MIPS_CPS_PM
23062306
bool
23072307

23082308
config MIPS_GIC_IPI
2309+
depends on MIPS_GIC
23092310
bool
23102311

23112312
config MIPS_CM

0 commit comments

Comments
 (0)