wifi: wilc1000: fix potential memory leak in wilc_mac_xmit()

Zhang Changzhong · Sasha Levin · commit 8413cdec252f · 2023-03-10T11:38:13.000Z
[ Upstream commit deb962e ] The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add dev_kfree_skb() to fix it. Compile tested only. Fixes: c5c77ba ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/staging/wilc1000/wilc_netdev.c b/drivers/staging/wilc1000/wilc_netdev.c
@@ -717,6 +717,7 @@ netdev_tx_t wilc_mac_xmit(struct sk_buff *skb, struct net_device *ndev)
 
 	if (skb->dev != ndev) {
 		netdev_err(ndev, "Packet not destined to this device\n");
+		dev_kfree_skb(skb);
 		return NETDEV_TX_OK;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -717,6 +717,7 @@ netdev_tx_t wilc_mac_xmit(struct sk_buff skb, struct net_device ndev)`
`717`	`717`
`718`	`718`	`if (skb->dev != ndev) {`
`719`	`719`	`netdev_err(ndev, "Packet not destined to this device\n");`
	`720`	`+ dev_kfree_skb(skb);`
`720`	`721`	`return NETDEV_TX_OK;`
`721`	`722`	`}`
`722`	`723`