exportfs: fix 'passing zero to ERR_PTR()' warning

YueHaibing · Al Viro · commit 909e22e05353 · 2018-11-18T23:47:56.000-05:00
Fix a static code checker warning: fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR' The error path for lookup_one_len_unlocked failure should set err to PTR_ERR. Fixes: bbf7a8a ("exportfs: move most of reconnect_path to helper function") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c
@@ -147,6 +147,7 @@ static struct dentry *reconnect_one(struct vfsmount *mnt,
 	tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf));
 	if (IS_ERR(tmp)) {
 		dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
+		err = PTR_ERR(tmp);
 		goto out_err;
 	}
 	if (tmp != dentry) {

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,7 @@ static struct dentry reconnect_one(struct vfsmount mnt,`
`147`	`147`	`tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf));`
`148`	`148`	`if (IS_ERR(tmp)) {`
`149`	`149`	`dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));`
	`150`	`+ err = PTR_ERR(tmp);`
`150`	`151`	`goto out_err;`
`151`	`152`	`}`
`152`	`153`	`if (tmp != dentry) {`