Bluetooth: btintel: make array 'param' static, shrinks object size

Colin Ian King · holtmann · commit 948c7ca03c14 · 2018-01-08T21:44:22.000+01:00
Don't populate the const read-only array 'param' on the stack but instead
make it static. Makes the object code smaller by nearly 20 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  11605	   2629	     64	  14298	   37da	linux/drivers/bluetooth/btintel.o

After:
   text	   data	    bss	    dec	    hex	filename
  11531	   2685	     64	  14280	   37c8	linux/drivers/bluetooth/btintel.o

(gcc version 7.2.0 x86_64)

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Marcel Holtmann &lt;marcel@holtmann.org&gt;
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
@@ -75,7 +75,7 @@ EXPORT_SYMBOL_GPL(btintel_check_bdaddr);
 
 int btintel_enter_mfg(struct hci_dev *hdev)
 {
-	const u8 param[] = { 0x01, 0x00 };
+	static const u8 param[] = { 0x01, 0x00 };
 	struct sk_buff *skb;
 
 	skb = __hci_cmd_sync(hdev, 0xfc11, 2, param, HCI_CMD_TIMEOUT);

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ EXPORT_SYMBOL_GPL(btintel_check_bdaddr);`
`75`	`75`
`76`	`76`	`int btintel_enter_mfg(struct hci_dev *hdev)`
`77`	`77`	`{`
`78`		`- const u8 param[] = { 0x01, 0x00 };`
	`78`	`+ static const u8 param[] = { 0x01, 0x00 };`
`79`	`79`	`struct sk_buff *skb;`
`80`	`80`
`81`	`81`	`skb = __hci_cmd_sync(hdev, 0xfc11, 2, param, HCI_CMD_TIMEOUT);`