clk: zynqmp: Off by one in zynqmp_is_valid_clock()

Dan Carpenter · bebarino · commit 9a43be9cedd5 · 2018-12-03T09:54:48.000-08:00
The > comparison should be >= to prevent reading beyond the end of the clock[] array. (The clock[] array is allocated in zynqmp_clk_setup() and has clock_max_idx elements.) Fixes: 3fde0e1 ("drivers: clk: Add ZynqMP clock driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c
@@ -128,7 +128,7 @@ static const struct zynqmp_eemi_ops *eemi_ops;
  */
 static inline int zynqmp_is_valid_clock(u32 clk_id)
 {
-	if (clk_id > clock_max_idx)
+	if (clk_id >= clock_max_idx)
 		return -ENODEV;
 
 	return clock[clk_id].valid;

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ static const struct zynqmp_eemi_ops *eemi_ops;`
`128`	`128`	`*/`
`129`	`129`	`static inline int zynqmp_is_valid_clock(u32 clk_id)`
`130`	`130`	`{`
`131`		`- if (clk_id > clock_max_idx)`
	`131`	`+ if (clk_id >= clock_max_idx)`
`132`	`132`	`return -ENODEV;`
`133`	`133`
`134`	`134`	`return clock[clk_id].valid;`