Skip to content

Commit abe48b1

Browse files
lenbH. Peter Anvin
authored andcommitted
x86, intel, power: Initialize MSR_IA32_ENERGY_PERF_BIAS
Since 2.6.36 (23016bf), Linux prints the existence of "epb" in /proc/cpuinfo, Since 2.6.38 (d5532ee), the x86_energy_perf_policy(8) utility has been available in-tree to update MSR_IA32_ENERGY_PERF_BIAS. However, the typical BIOS fails to initialize the MSR, presumably because this is handled by high-volume shrink-wrap operating systems... Linux distros, on the other hand, do not yet invoke x86_energy_perf_policy(8). As a result, WSM-EP, SNB, and later hardware from Intel will run in its default hardware power-on state (performance), which assumes that users care for performance at all costs and not for energy efficiency. While that is fine for performance benchmarks, the hardware's intended default operating point is "normal" mode... Initialize the MSR to the "normal" by default during kernel boot. x86_energy_perf_policy(8) is available to change the default after boot, should the user have a different preference. Signed-off-by: Len Brown <len.brown@intel.com> Link: http://lkml.kernel.org/r/alpine.LFD.2.02.1107140051020.18606@x980 Acked-by: Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com> Cc: <stable@kernel.org>
1 parent 620917d commit abe48b1

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

arch/x86/include/asm/msr-index.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,9 @@
259259
#define MSR_IA32_TEMPERATURE_TARGET 0x000001a2
260260

261261
#define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0
262+
#define ENERGY_PERF_BIAS_PERFORMANCE 0
263+
#define ENERGY_PERF_BIAS_NORMAL 6
264+
#define ENERGY_PERF_BIAS_POWERSWAVE 15
262265

263266
#define MSR_IA32_PACKAGE_THERM_STATUS 0x000001b1
264267

arch/x86/kernel/cpu/intel.c

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -456,6 +456,24 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
456456

457457
if (cpu_has(c, X86_FEATURE_VMX))
458458
detect_vmx_virtcap(c);
459+
460+
/*
461+
* Initialize MSR_IA32_ENERGY_PERF_BIAS if BIOS did not.
462+
* x86_energy_perf_policy(8) is available to change it at run-time
463+
*/
464+
if (cpu_has(c, X86_FEATURE_EPB)) {
465+
u64 epb;
466+
467+
rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
468+
if ((epb & 0xF) == 0) {
469+
printk_once(KERN_WARNING, "x86: updated energy_perf_bias"
470+
" to 'normal' from 'performance'\n"
471+
"You can view and update epb via utility,"
472+
" such as x86_energy_perf_policy(8)\n");
473+
epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
474+
wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
475+
}
476+
}
459477
}
460478

461479
#ifdef CONFIG_X86_32

0 commit comments

Comments
 (0)