Skip to content

Commit c7dfc8c

Browse files
atenartdavem330
authored andcommitted
net: mvpp2: do not select the internal source clock
This patch stops the internal MAC Tx clock from being enabled as the internal clock isn't used. The definition used for the bit controlling this behaviour is renamed as well as it was wrongly named (bit 4 of GMAC_CTRL_2_REG). Fixes: 3919357 ("net: mvpp2: initialize the GMAC when using a port") Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 6bf69a1 commit c7dfc8c

File tree

1 file changed

+1
-2
lines changed
  • drivers/net/ethernet/marvell

1 file changed

+1
-2
lines changed

drivers/net/ethernet/marvell/mvpp2.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@
333333
#define MVPP2_GMAC_INBAND_AN_MASK BIT(0)
334334
#define MVPP2_GMAC_FLOW_CTRL_MASK GENMASK(2, 1)
335335
#define MVPP2_GMAC_PCS_ENABLE_MASK BIT(3)
336-
#define MVPP2_GMAC_PORT_RGMII_MASK BIT(4)
336+
#define MVPP2_GMAC_INTERNAL_CLK_MASK BIT(4)
337337
#define MVPP2_GMAC_DISABLE_PADDING BIT(5)
338338
#define MVPP2_GMAC_PORT_RESET_MASK BIT(6)
339339
#define MVPP2_GMAC_AUTONEG_CONFIG 0xc
@@ -4599,7 +4599,6 @@ static void mvpp2_port_mii_gmac_configure(struct mvpp2_port *port)
45994599
val |= MVPP2_GMAC_INBAND_AN_MASK | MVPP2_GMAC_PCS_ENABLE_MASK;
46004600
} else if (phy_interface_mode_is_rgmii(port->phy_interface)) {
46014601
val &= ~MVPP2_GMAC_PCS_ENABLE_MASK;
4602-
val |= MVPP2_GMAC_PORT_RGMII_MASK;
46034602
}
46044603
writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
46054604

0 commit comments

Comments
 (0)