Skip to content

Commit d2f2f1d

Browse files
jpbruckerjoergroedel
authored andcommitted
dt-bindings: iommu: arm,smmu-v3: Relax order of interrupt names
The QEMU devicetree uses a different order for SMMUv3 interrupt names, and there isn't a good reason for enforcing a specific order. Since all interrupt lines are optional, operating systems should not expect a fixed interrupt array layout; they should instead match each interrupt to its name individually. Besides, as a result of commit e478385 ("dt-bindings: iommu: arm,smmu-v3: make PRI IRQ optional"), "cmdq-sync" and "priq" are already permutable. Relax the interrupt-names array entirely by allowing any permutation, incidentally making the schema more readable. Note that dt-validate won't allow duplicate names here so we don't need to specify maxItems or add additional checks, it's quite neat. Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> Acked-by: Will Deacon <will@kernel.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20220916133145.1910549-1-jean-philippe@linaro.org Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 7e18e42 commit d2f2f1d

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,11 @@ properties:
3939
any others.
4040
- minItems: 1
4141
items:
42-
- enum:
43-
- eventq # Event Queue not empty
44-
- gerror # Global Error activated
45-
- const: gerror
46-
- enum:
47-
- cmdq-sync # CMD_SYNC complete
48-
- priq # PRI Queue not empty
49-
- enum:
50-
- cmdq-sync
51-
- priq
42+
enum:
43+
- eventq # Event Queue not empty
44+
- gerror # Global Error activated
45+
- cmdq-sync # CMD_SYNC complete
46+
- priq # PRI Queue not empty
5247

5348
'#iommu-cells':
5449
const: 1

0 commit comments

Comments
 (0)