Skip to content

Commit db476e8

Browse files
aabodunrinJeff Kirsher
authored andcommitted
igb: No PHPM support in i354 devices
PHY Power Management does not exist for i354 device. So, there is no need to read and write this register or clear go link Disconnect bit, which could cause a lot of issues. Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
1 parent dfc7075 commit db476e8

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

drivers/net/ethernet/intel/igb/e1000_82575.c

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1421,11 +1421,18 @@ static s32 igb_setup_copper_link_82575(struct e1000_hw *hw)
14211421
ctrl &= ~(E1000_CTRL_FRCSPD | E1000_CTRL_FRCDPX);
14221422
wr32(E1000_CTRL, ctrl);
14231423

1424-
/* Clear Go Link Disconnect bit */
1425-
if (hw->mac.type >= e1000_82580) {
1424+
/* Clear Go Link Disconnect bit on supported devices */
1425+
switch (hw->mac.type) {
1426+
case e1000_82580:
1427+
case e1000_i350:
1428+
case e1000_i210:
1429+
case e1000_i211:
14261430
phpm_reg = rd32(E1000_82580_PHY_POWER_MGMT);
14271431
phpm_reg &= ~E1000_82580_PM_GO_LINKD;
14281432
wr32(E1000_82580_PHY_POWER_MGMT, phpm_reg);
1433+
break;
1434+
default:
1435+
break;
14291436
}
14301437

14311438
ret_val = igb_setup_serdes_link_82575(hw);

0 commit comments

Comments
 (0)