Skip to content

Commit e608787

Browse files
arndbairlied
authored andcommitted
drm/sti: restore mode_fixup callback
Commit 8a2fa38 removed the mode_fixup because it was empty, but 652353e modified it to call drm_mode_set_crtcinfo() instead. Both commits are correct, but the merge of the two kept the nonempty version without the reference to it, as shown by the gcc warning: drm/sti/sti_crtc.c:54:13: error: 'sti_crtc_mode_fixup' defined but not used This restores the callback pointer to fix the merge. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reverts: 8a2fa38 ("drm/sti: removed optional dummy crtc mode_fixup function.") Fixes: 652353e ("drm/sti: set CRTC modesetting parameters") Fixes: cf48106 ("Merge branch '2016-02-26-st-drm-next' of http://git.linaro.org/people/benjamin.gaignard/kernel into drm-next") Acked-by: Vincent ABRIOU <vincent.abriou@st.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
1 parent cf48106 commit e608787

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/sti/sti_crtc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,7 @@ static void sti_crtc_atomic_flush(struct drm_crtc *crtc,
230230
static const struct drm_crtc_helper_funcs sti_crtc_helper_funcs = {
231231
.enable = sti_crtc_enable,
232232
.disable = sti_crtc_disabling,
233+
.mode_fixup = sti_crtc_mode_fixup,
233234
.mode_set = drm_helper_crtc_mode_set,
234235
.mode_set_nofb = sti_crtc_mode_set_nofb,
235236
.mode_set_base = drm_helper_crtc_mode_set_base,

0 commit comments

Comments
 (0)