Skip to content

Commit f3c1fd0

Browse files
chuckleverJ. Bruce Fields
authored andcommitted
svcrdma: Reduce max_send_sges
There's no need to request a large number of send SGEs because the inline threshold already constrains the number of SGEs per Send. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
1 parent 0ac203c commit f3c1fd0

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

net/sunrpc/xprtrdma/svc_rdma_transport.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -475,10 +475,12 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
475475

476476
/* Qualify the transport resource defaults with the
477477
* capabilities of this particular device */
478-
newxprt->sc_max_send_sges = dev->attrs.max_send_sge;
479-
/* transport hdr, head iovec, one page list entry, tail iovec */
480-
if (newxprt->sc_max_send_sges < 4) {
481-
pr_err("svcrdma: too few Send SGEs available (%d)\n",
478+
/* Transport header, head iovec, tail iovec */
479+
newxprt->sc_max_send_sges = 3;
480+
/* Add one SGE per page list entry */
481+
newxprt->sc_max_send_sges += svcrdma_max_req_size / PAGE_SIZE;
482+
if (newxprt->sc_max_send_sges > dev->attrs.max_send_sge) {
483+
pr_err("svcrdma: too few Send SGEs available (%d needed)\n",
482484
newxprt->sc_max_send_sges);
483485
goto errout;
484486
}

0 commit comments

Comments
 (0)