net: ethernet: aquantia: remove another redundant err check

Colin Ian King · davem330 · commit f81e5ca9155e · 2017-01-29T18:24:00.000-05:00
The check on err &lt; 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398318 ("Logically Dead Code")

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -304,8 +304,6 @@ int aq_ring_rx_fill(struct aq_ring_s *self)
 
 		buff = NULL;
 	}
-	if (err < 0)
-		goto err_exit;
 
 err_exit:
 	if (err < 0) {

Original file line number	Diff line number	Diff line change
`@@ -304,8 +304,6 @@ int aq_ring_rx_fill(struct aq_ring_s *self)`
`304`	`304`
`305`	`305`	`buff = NULL;`
`306`	`306`	`}`
`307`		`- if (err < 0)`
`308`		`- goto err_exit;`
`309`	`307`
`310`	`308`	`err_exit:`
`311`	`309`	`if (err < 0) {`