-
Notifications
You must be signed in to change notification settings - Fork 35
Additional serialization tests #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Seems like it's only failing for me with the pip installation, the test passes when I install it from scratch. I must have misunderstood what you meant when you said you introduced a failing test. My mistake... With pip, I get this error(version 0.4.3)r: |
Looks like pip thinks it has v0.4.4 of Embedly, even though the source says 0.4.3. To avoid confusion, I bumped the version to 0.4.5. Is there any reason the newest code isn't released on pip? We're running into the old serialization problem on the project I'm on. It would be nice to just use the pip version instead of having to keep our own copy. |
Okay great, that jives with my experience. The packaging versioning is somehow off. PyPI reports In the meantime, to avoid having your own copy, you could tell Pip to grab the Github version with this: Though disappointingly that dies on |
PR #19 fixes the import issue. |
Sweet, thanks! That command looks super helpful(I'm new to python). I'll be sure to use that as soon as PR#19 gets accepted. |
Welcome to Python! The pip command is very useful in that way—you can give it a Github location with branch name or commit hash and the Also glad I found that circular import logic. Good to fix that before the official release was attempted. We should let the Embedly team determine the actual release version number, but I vote to keep your additional test data. |
Thanks! Just got rid of the commit to bump the version. The additional testing doesn't add much, but if the Embedly team wants it I'm always happy to have a pull request accepted. We'll just have to wait and see... |
additional serialization tests (a part of this initial PR was reverted; now it's just more test data)
Not sure if there are more edge cases I missed, but this change got the existing failing test to pass. It also fixes the problem I'm facing of serialization with cPickle.
I also added some cases to the old failing test just to make sure serializing lots of data types worked.