Fix disabled widgets "eating" focus #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01faa55 to
3dfacda
Compare
|
Preview available at https://egui-pr-preview.github.io/pr/5370-lucas/fix-disabled-widgets-eating-focus |
1 task
abey79
approved these changes
Nov 20, 2024
emilk
approved these changes
Nov 26, 2024
Comment on lines
+12
to
+29
|
|
||
| harness.press_key(egui::Key::Tab); | ||
| harness.run(); | ||
|
|
||
| let button_1 = harness.get_by_name("Button 1"); | ||
| assert!(button_1.is_focused()); | ||
|
|
||
| harness.press_key(egui::Key::Tab); | ||
| harness.run(); | ||
|
|
||
| let button_3 = harness.get_by_name("Button 3"); | ||
| assert!(button_3.is_focused()); | ||
|
|
||
| harness.press_key(egui::Key::Tab); | ||
| harness.run(); | ||
|
|
||
| let button_1 = harness.get_by_name("Button 1"); | ||
| assert!(button_1.is_focused()); |
lucasmerlin
added a commit
that referenced
this pull request
Nov 28, 2024
* Closes #686 * Closes #839 * #5370 should be merged before this * [x] I have followed the instructions in the PR template This adds modals to egui. This PR - adds a new `Modal` struct - adds `Memory::set_modal_layer` to limit focus to a layer and above (used by the modal struct, but could also be used by custom modal implementations) - adds `Memory::allows_interaction` to check if a layer is behind a modal layer, deprecating `Layer::allows_interaction` Current problems: - ~When a button is focused before the modal opens, it stays focused and you also can't hit tab to focus the next widget. Seems like focus is "stuck" on that widget until you hit escape. This might be related to #5359 fixed! Possible future improvements: - The titlebar from `window` should be made into a separate widget and added to the modal - The state whether the modal is open should be stored in egui (optionally), similar to popup and menu. Ideally before this we would refactor popup state to unify popup and menu --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the test I added a
Harness::press_keyfunction. We should eventually add these to kittest, probably via a trait one can implement for theHarnessbut for now this should do.