Skip to content

Add a small section describing the pyproject.toml file #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2024

Conversation

yakutovicha
Copy link
Member

fixes #196

@yakutovicha yakutovicha requested review from despadam and baffelli May 3, 2024 16:58
Copy link
Member

@baffelli baffelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. However, in Jupyter lab, this cell does not render correctly:
grafik

It looks correct on vscode. Do you know why? Can we find out if this is a general problem or if there's some issue with the cell?

@despadam despadam added the upcoming tutorial Stuff to work on/fix before the next tutorial label May 4, 2024
@despadam
Copy link
Contributor

despadam commented May 4, 2024

It also looks good to me and it looks like it renders correctly in Jupyter Lab:

image

@baffelli
Copy link
Member

baffelli commented May 4, 2024

It also looks good to me and it looks like it renders correctly in Jupyter Lab:

image

Must be a problem with my installation. We can merge!

@baffelli baffelli dismissed their stale review May 4, 2024 18:49

Looks fine

@despadam despadam merged commit bb38e3c into main May 4, 2024
1 check passed
@despadam despadam deleted the fix/196-modules-and-packages branch May 4, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming tutorial Stuff to work on/fix before the next tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganise "Modules and Packages" and "Manage Python project"
3 participants