Simplify and optimize Docker image #264
Conversation
for more information, see https://pre-commit.ci
|
@edoardob90 do you need a review on this? I could give a hand. |
If you want, you can try to build the container from the Dockerfile. I tested the workflow in the |
There was a problem hiding this comment.
Thanks, @edoardob90, I did a first pass and I would need some clarifications from your side.
707acaf to
3786be6
Compare
|
Options: Leave the
|
|
@yakutovicha I think we need to resume/finalize this. It would simplify a lot the build step of the image, and solve the recent problem with the workflow run that, all of a sudden, ran out of disk space on the hosted runner. If we're deploying only on Renkulab, the |
* Trigger build for PR, but only when from the same repo * Multi-arch build * Uses "docker/metadata" action to set up labels and tags
* Keep only branch, pr, and SHA * Add repo tags vX.Y or vX.Y.Z
jupyter-repo2dockerdependencydocker/environment.ymlThe old workflow has been renamed to
.github/workflows/repo2docker.ymland Binder is still supported via thebinder/directory (unchanged).Also: since Docker provides already the isolation, there's no need to have another virtual environment. All the tutorial dependencies are installed in the
baseenvironment, which is automatically configured by the base image.