Make sdl-config/sdl2-config into simple shell scripts #24907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Aug 11, 2025
9de58eb to
537790b
Compare
This removes the python dependency and the need to .bat and shell launchers. These script have always be shell scripts upstream and there should be no expectation that they can be run on windows. See libsdl-org/SDL#3516 In addition fix `sdl-config.py` so that it explicitly includes `-sUSE_SDL`. This has been required since emscripten-core#18443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the python dependency and the need to .bat and shell launchers.
These script have always be shell scripts upstream and there should be no expectation that they can be run on windows.
See libsdl-org/SDL#3516
In addition fix
sdl-config.pyso that it explicitly includes-sUSE_SDL. This has been required since #18443.