Mark --preload-file as incompatible with MINIMAL_RUNTIME. NFC
#24910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0411c0a to
4f8943c
Compare
kripken
approved these changes
Aug 12, 2025
The file preloading mechanism relies on either `Module.preRun` or `Module.calledRun`, neither of which are available with `MINIMAL_RUNTIME`. The FS_createPreloadedFile fundamtentenally does not work yet under `MINIMAL_RUNTIME` since it depends on the `readAsync` runtime functions which does not exist in that mode.
4f8943c to
ce2d9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file preloading mechanism relies on either
Module.preRunorModule.calledRun, neither of which are available withMINIMAL_RUNTIME.