Skip to content

Version 0.5.4 #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Version 0.5.4 #441

merged 2 commits into from
Jan 14, 2022

Conversation

aminalaee
Copy link
Member

@aminalaee aminalaee commented Jan 6, 2022

https://github.com/encode/databases/releases/edit/untagged-d723639e4d24f39254b7

Changelog:

Added

Fixed

@collerek
Copy link
Member

collerek commented Jan 7, 2022

@vmarkovtsev Any chance in helping to push this out?
You seem to be one of the last active maintainers apart from @aminalaee 😅

@collerek
Copy link
Member

@tomchristie Can we do anything about helping with the maintenance of this project?
I know a lot of people switched to sqlalchemy since they introduced async support, yet the databases library is still quite popular and there are very few active maintainers. I can help with reviews if there is no one else that has time for this.

@tomchristie
Copy link
Member

@collerek - I can add you to @encode/maintainers and walk you through how to perform releases if you'd like?

@collerek
Copy link
Member

@collerek - I can add you to @encode/maintainers and walk you through how to perform releases if you'd like?

@tomchristie Sure, happy to help :)

@tomchristie
Copy link
Member

Okay - invite sent.

What needs doing at the moment?

@aminalaee
Copy link
Member Author

We need to approve this PR and release next version: https://github.com/encode/databases/releases/edit/untagged-d723639e4d24f39254b7

@tomchristie
Copy link
Member

Okay - does someone want to compile the release notes for 0.5.4?
(Even if that's just a comment on this thread, then I can help walk @collerek through the release process.)

@aminalaee
Copy link
Member Author

Sure, I'll do that.

@aminalaee
Copy link
Member Author

@tomchristie @collerek I think version 0.6.0 would make more sense here.

@collerek
Copy link
Member

@tomchristie @collerek I think version 0.6.0 would make more sense here.

Not sure what is the encode policy here.
Normally when you reach 1.0.0 it's usually {breaking}:{feature}:{patch (bug fix)}.
But before 1.0.0 it's also often (fixed 0):{breaking}:{feature & bug fix}

@tomchristie
Copy link
Member

What @collerek said, yup.
We'd also do a 0.x bump if a feature was big enough to be worth calling out.

@aminalaee
Copy link
Member Author

aminalaee commented Jan 14, 2022

Great, that makes sense. If it gets approved we can do the release.

@tomchristie
Copy link
Member

Okay - I'm happy with this.

Right then @collerek you're welcome to merge this now.

Once it's merged done you can go to the draft release - https://github.com/encode/databases/releases/tag/untagged-0d04003928428cecab79 - edit it and hit "Publish".

@aminalaee aminalaee merged commit f6b28ad into master Jan 14, 2022
@aminalaee aminalaee deleted the version-0.5.4 branch January 14, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants