Skip to content

ReturnDict fails with union operator (PEP 584) #8301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 3 tasks
spookylukey opened this issue Dec 17, 2021 · 1 comment
Closed
2 of 3 tasks

ReturnDict fails with union operator (PEP 584) #8301

spookylukey opened this issue Dec 17, 2021 · 1 comment

Comments

@spookylukey
Copy link
Contributor

spookylukey commented Dec 17, 2021 •
edited
Loading

Simplest case. Under Python 3.9:

>>> from rest_framework.serializers import Serializer
>>> Serializer().data | {}

Expected output:

{}

Actual behaviour:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/luke/devel/django-rest-framework/rest_framework/utils/serializer_helpers.py", line 17, in __init__
    self.serializer = kwargs.pop('serializer')
KeyError: 'serializer'

I will provide a PR soon.

Checklist

  • I did not raise a discussion, as this is obviously a bug
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
spookylukey added a commit to spookylukey/django-rest-framework that referenced this issue Dec 17, 2021
@spookylukey
ReturnDict should support dict union operators on Python 3.9
fd81726 
Fixes issue encode#8301
spookylukey added a commit to spookylukey/django-rest-framework that referenced this issue Dec 17, 2021
@spookylukey
Make ReturnDict support dict union operators on Python 3.9 and later
a5966e9 
Fixes issue encode#8301
@spookylukey spookylukey mentioned this issue Dec 17, 2021
Merged
tomchristie pushed a commit that referenced this issue Dec 22, 2021
@spookylukey
Make ReturnDict support dict union operators on Python 3.9 and later (#…
bce9df9 
…8302)

Fixes issue #8301
@tomchristie
Copy link
Member

Closed via 8302

sigvef pushed a commit to sigvef/django-rest-framework that referenced this issue Dec 3, 2022
@spookylukey @sigvef
Make ReturnDict support dict union operators on Python 3.9 and later (e…
3735de6 
…ncode#8302)

Fixes issue encode#8301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spookylukey @tomchristie