Allow use of native migrations in 1.7 — Take 2 #1654
Conversation
…IGRATION_MODULES` setting from `rest_framework.settings`
…into encode#1559 Conflicts: docs/topics/release-notes.md
|
Thanks for the work on this, looking forward for the merge and a subsequent release. 1.7 RC is coming up in the next few days and many projects have started migrating. |
|
I doubt many projects have migrated. There are many libraries that are not compatible with the new app refactoring yet. Been bitten a lot with this. |
|
This looks good to me. |
|
I still need to alter the docs re migration dependencies. See comment I'm hoping it's just the name change but the Django docs example uses "migration" — or similar — as the key which confused me, so I wanted to take a moment to make sure I'm on top of it. If the pull is okay other than that I'll get it done. |
|
|
||
| --- | ||
|
|
||
| **Note:** Make sure to run `manage.py syncdb` after changing your settings. Both Django native (from v1.7) and South migrations for the `authtoken` database tables are provided. See [Schema migrations](#schema-migrations) below. |
There was a problem hiding this comment.
I would probably re-word this and similar paragraphs, to change the emphasis. Eg, Migrations for the authtoken database tables are provided, and include both Django 1.7 and South migration files.
|
Looks like we could recommend South 1.0 instead of any settings changes... http://www.aeracode.org/2014/7/1/end-era/ |
|
Agreed. |
Pleased with my psychic powers there. |
Well played. 👏 |
|
I have a Django 1.7c1 project that's pending the Is there anything I can do to help speed up this PR? |
Argh! I just need to write the docs here and I think it's good to go — but it's targeting 2.4 — When's that due to go? (I can make the time if it's imminent. As ever just been otherwise engaged.) |
|
@carltongibson I may have some time to review the 2.4 status in a week or two. Main thing is for us to review/check what's actually changed, given it's been outstanding for so long. |
|
OK — I'll take on the docs before then. |
|
OK — docs updated. |
|
@carltongibson thanks for dealing with this |
|
@xordoquy — it's a pleasure :) — it's been a bit like pulling teeth finding time recently... |
|
Presumably this is good to merge into 2.4 now then? |
I think so. New migration added. Old migration moved. Note to upgrade to South 1.0 (if needed) added to docs and release notes. Anything else? |
|
Feeling like it's ready to merge ! |
Allow use of native migrations in 1.7 — Take 2
|
Rockin' - nice work! |
For #1559 take 2. Replaces #1653.
(The branch name was obviously causing GitHub some confusion...)
Merges against 2.4.0 branch (since it's a small breaking change).