Skip to content

s/throtte/throttle/ #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jvoorhis
Copy link

@jvoorhis jvoorhis commented Jul 7, 2014

Sorry for the pedantry!

@kevin-brown
Copy link
Member

While I definitely think this should be fixed, it would invalidate all of the past throttles which probably isn't ideal.

@tomchristie
Copy link
Member

Good spot! We probably need to do this on a medium/major version change and note the incompatibility.

@jvoorhis
Copy link
Author

jvoorhis commented Jul 7, 2014

@tomchristie agreed, a rollout could cause increased cache usage or thundering herd problems. It's no problem for me, since I'm working on a new project :)

@tomchristie tomchristie added this to the 3.0 Release milestone Aug 18, 2014
@tomchristie
Copy link
Member

Let's bundle this in for 3.0

@tomchristie
Copy link
Member

Just considering if might be worth bundling into 2.4 - #1770 - since it's about ready to go.

@tomchristie tomchristie modified the milestones: 3.0 Release, 2.4 Release Aug 20, 2014
@tomchristie
Copy link
Member

Let's just do this in 2.4. We can note how to continue with backwards compat in the release notes.

@tomchristie
Copy link
Member

Thanks for this! Now closed by 59b47ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants