Skip to content

Bugfix/1398 #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2014
Merged

Bugfix/1398 #1778

merged 3 commits into from
Aug 19, 2014

Conversation

xordoquy
Copy link
Collaborator

Ported #1398 to 2.4 branch.

@tomchristie tomchristie added this to the 2.4 Release milestone Aug 19, 2014
@charettes
Copy link
Contributor

The build failure is directly related to the conflicting model name I reported 6 months ago.

@tomchristie
Copy link
Member

@charettes Want to expand in a more actionable way - specifically what needs to change here?
I'd prefer those models to be in the scope of the test unless there's a reason why that's not possible - make sense right?

@xordoquy
Copy link
Collaborator Author

Actually I moved those models for the 1.7 compat and the merge added them a second time.
@tomchristie this is still possible but they need to have different names.

@charettes
Copy link
Contributor

@tomchristie they'll need different names in this case.

tomchristie added a commit that referenced this pull request Aug 19, 2014
@tomchristie tomchristie merged commit 5358243 into encode:2.4.0 Aug 19, 2014
@xordoquy xordoquy deleted the bugfix/1398 branch December 10, 2014 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants