Cherry picks #3184
Cherry picks #3184
Conversation
Upgrade guardian support to 1.3. encode#3165
|
@xordoquy Do we want to support a 2.4.7? You're the one having to deal with those releases ATM, so kinda up to how you feel about if they're worth the effort right now or now (If it was just me I'd be writing them off) |
| if guardian.VERSION >= (1, 3): | ||
| # Maintain behavior compatibility with versions prior to 1.3 | ||
| extra = {'accept_global_perms': False} | ||
| return guardian.shortcuts.get_objects_for_user(user, permission, queryset, **extra) |
There was a problem hiding this comment.
Noticed that this will break for version prior to 1.3 (extra won't be defined)
Resolved in master just now but your PR would also need to be updated too.
|
Thanks for the heads-up, that should learn me for cherry picking a commit without fully checking ;-) |
|
I'll merge this in, tho keep in mind that we don't yet have any commitment on a 2.4.7 release. |
Support Django Guardian 1.3
|
Ping me next week. I'll try to get the next 3.2 this week and then I'll be able to do one 2.4 after that. |
|
Hi Xavier, |
|
In the interim you can of course override the filter class and configure REST framework to use your custom (fixed) filter. |
|
2.4.8 is out - I messed up with 2.4.7. |
Upgrade guardian support to 1.3. #3165
Is it possible to port this fix in time for 2.4.7? Apologies if this is not the correct procedure, or if this is already in hand.
Thanks for all the hard work!