Unsupported media type is not raised when posting a form #3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a bit of a glaring one - thanks for the test case pull request! To consider - is this related to #1769? |
|
I am not familiar with the DRF code, but I tried adding a breakpoint to the |
|
Merged these tests into #3410, which resolves this. Thanks! |
edmorley
pushed a commit
to mozilla/treeherder
that referenced
this pull request
Nov 13, 2015
The default format used to make test requests is `multipart/form-data`, unless overridden using `TEST_REQUEST_DEFAULT_FORMAT`: http://www.django-rest-framework.org/api-guide/testing/#setting-the-default-format Our API only accepts json and html (see `DEFAULT_RENDERER_CLASSES`), so we should have always been setting `TEST_REQUEST_DEFAULT_FORMAT` to `json`, to prevent test failures. However until recently there was a bug preventing those failures: encode/django-rest-framework#3214 Which has now been fixed in django-rest-framwork v3.3.x: encode/django-rest-framework#3410 ...so we must fix this before updating to the latest version of d-r-f.
edmorley
pushed a commit
to mozilla/treeherder
that referenced
this pull request
Dec 6, 2015
The default format used to make test requests is `multipart/form-data`, unless overridden using `TEST_REQUEST_DEFAULT_FORMAT`: http://www.django-rest-framework.org/api-guide/testing/#setting-the-default-format Our API only accepts json and html (see `DEFAULT_RENDERER_CLASSES`), so we should have always been setting `TEST_REQUEST_DEFAULT_FORMAT` to `json`, to prevent test failures. However until recently there was a bug preventing those failures: encode/django-rest-framework#3214 Which has now been fixed in django-rest-framwork v3.3.x: encode/django-rest-framework#3410 ...so we must fix this before updating to the latest version of d-r-f.
edmorley
pushed a commit
to mozilla/treeherder
that referenced
this pull request
Dec 10, 2015
…pe json The default format used to make test requests is `multipart/form-data`, unless overridden using `TEST_REQUEST_DEFAULT_FORMAT`: http://www.django-rest-framework.org/api-guide/testing/#setting-the-default-format Our API only accepts json and html (see `DEFAULT_RENDERER_CLASSES`), so we should have always been setting `TEST_REQUEST_DEFAULT_FORMAT` to `json`, to prevent test failures. However until recently there was a bug preventing those failures: encode/django-rest-framework#3214 Which has now been fixed in django-rest-framwork v3.3.x: encode/django-rest-framework#3410 ...so we must fix this before updating to the latest version of d-r-f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A HTTP status 415 "Unsupported media type" is not raised when a simple form (application/x-www-form-urlencoded) is posted to a view that accepts only application/json.
When posting other content-types, the 415 status is raised as expected.
The pull request includes a failing test.