Fix issue #3951: Request.data empty when multipart/form-data POSTed #4026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Milestoning it to rise the priority on it |
|
Okay, needs some serious consideration. Thanks for your input on this. |
|
The thing that prevents me to merge this is my lack of understanding about the use of request.stream vs request.POST. |
|
Not a problem - I wouldn't want this merged without some in-depth review first, in any case. |
|
Superseeded by #4500. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed fix (and tests) for resolving issue #3951. Amends MultiPartParser to use underlying Django WSGIRequest POST and FILES rather than attempting to (potentially) re-read the POST stream.