Mentioning that '@detail_route' responds to GET only by default #4582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
reviewed
Oct 14, 2016
| @@ -51,7 +51,7 @@ This time we've used the `ModelViewSet` class in order to get the complete set o | |||
|
|
|||
| Notice that we've also used the `@detail_route` decorator to create a custom action, named `highlight`. This decorator can be used to add any custom endpoints that don't fit into the standard `create`/`update`/`delete` style. | |||
|
|
|||
| Custom actions which use the `@detail_route` decorator will respond to `GET` requests. We can use the `methods` argument if we wanted an action that responded to `POST` requests. | |||
| Custom actions which use the `@detail_route` decorator will, by default, respond to `GET` requests. We can use the `methods` argument if we wanted an action that responded to `POST` requests. | |||
There was a problem hiding this comment.
Could we instead phrase this as "Custom actions which use the @detail_route decorator will respond to GET requests by default"?
fe71847 to
3d1bcf0
Compare
|
Done! Please have a look. |
tomchristie
approved these changes
Oct 18, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small change to documentation for clarity.