PEP8 and pyflakes fixes #4610
Closed
PEP8 and pyflakes fixes #4610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrmph, just realized that Or better, start following E501 :-) |
|
The Different approach needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #4600 and fixes the pyflakes problems produced there. Unfortunately (fortunately!), this exposed a bunch of PEP8 warnings that are now fixed. I was pretty rigorous about the line length.
One thing that some people might not like is that where it used to say
serializers.Serializerin the files I changed, it now saysSerializer. I'm not averse to the other way but it was a simpler fix to just move it over since we were using classes likeserializers.ModelFieldall over the place which was incorrect becauseModelFieldis infields.I did not change any functionality nor fix any code warnings - just formatting and imports.