converted primary key relations test asserts to pytest #4709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would be:
would be: |
|
thanks done. |
|
Yup, looks good - thanks! |
|
I need another help fro you. any cheetsheet for unittest to pytest asserts? that would be very helpful and less time consuming for all of us i guess. |
|
Nothing I know of. |
|
Neither do I. Most are just straight forward. The only one I've seen that doesn't match that pattern is the |
|
OK. Im OK with most of them but some are not. I will check out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure about how assertNumqueries should be converted
not sure about self.assertNotIn('target', serializer.validated_data)
and self.assertTrue(serializer.is_valid(), serializer.errors) ?
@xordoquy can you suggest?