Fixed ListField empty check which ignored multi-part list elements #4763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
requested changes
Dec 23, 2016
|
@tomchristie Done |
tomchristie
requested changes
Jan 1, 2017
| regexp = re.compile(html.HTML_LIST_REGEXP_FORMAT % re.escape(self.field_name)) | ||
| if not any(regexp.match(key) for key in dictionary.keys()): | ||
| return empty | ||
|
|
There was a problem hiding this comment.
I'm not comfortable moving the empty check entirely inside is_html_input - seems like we might be missing some failure cases that introduces that aren't covered by our test cases.
Any way around we could arrange this PR that has a smaller change footprint?
tomchristie
approved these changes
Jan 1, 2017
tomchristie
requested changes
Jan 1, 2017
|
I'm going to de-milestone for now. We'll come back to this after v3.7 |
|
I'm going to close this in favour of #5927. Thanks for the effort @NeveHanter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxed ListField empty check.
It was ignoring multi-part elements with parts like
emails[0],emails[1]because previous check logic only checked if field name (in this exampleemails) was in dictionary which won't match indexed list declarations.