Ensure that pagination is not included in API schema when page_size=None.
#4998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the default value was specified, it did not work properly in API Document
page_size=None.
|
Why are you checking page_size??? It is only PageNumberPagination related. Now LimitOffsetPagination not working with coreapi in v3.6.3. |
|
@khakulov you should open an issue describing the problem you are facing and mention this change. |
|
@khakulov the tone of the comment was misleading and no matter the reason you seem to hit a regression. We can't always think about all the use cases, there are many different so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there is a default value for pagination_class,
Also check page_size to see if the user is using it.
Closes #4996
Closes #4997