Fix model fields not being omitted on output/serialization #5473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"May be omitted" isn't the same as "Should be omitted". I'm not convinced we want this behavioral change, as is. |
|
Ok, how about if it were triggered (via |
|
@rpatterson - have you tested your project against the current master branch? #5375 made changes to the behavior of nested attribute access. |
|
Just merged master and tested, passes as before. Just pushed the merge.
…On Wed, Oct 4, 2017 at 9:00 AM Ryan P Kilby ***@***.***> wrote:
@rpatterson <https://github.com/rpatterson> - have you tested your
project against the current master branch? #5375
<#5375> made changes
to the behavior of nested attribute access.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5473 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANmAW2SpETZsnvSi4MwPGRf0JZA39g3ks5so6uRgaJpZM4PrJl->
.
|
It’s not really complexity I’d like to see us us add, no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation says about a field's
requiredargument:But this isn't the case for Django ORM model instances because they always return at least the field default so there's never an
AttributeError. This means that DRF's logic for omitting fields is never triggered and all model fields are always present in the JSON representation regardless of the field'srequiredargument.This PR fixes that by conditionally checking against the model field's default when the instance is a Django ORM model instance only when DRF's omit logic would take effect and forcing an
AttributeErrorin those cases. There's full test coverage for all the code this PR touches and there are no tox errors that I didn't also see when runagainstencode/master.http://www.django-rest-framework.org/api-guide/fields/#required