Add "optionals not required" build #6047
Conversation
| deps = | ||
| django | ||
| -rrequirements/requirements-testing.txt | ||
|
|
There was a problem hiding this comment.
While this looks more sane, my approach allows to use -base for everything (i.e. the different Django versions).
There was a problem hiding this comment.
True, although I'm not sure if it's entirely necessary to have that capability. The basic compat checks are generally going to work, regardless of base Python and Django versions. It should be sufficient just to check once.
In contrast to #6041, testing the optional code was more important, as compatibility between the optional dependencies and the various versions of Python and Django would not be guaranteed.
|
You should also rename the PR and commit then: "Test base without optionals explicitly" (or similar) |
|
I always wish GitHub had an asides comment feature... 🙂 I think running with optionals is the way to go. A lot of our users are using Postgres and/or Django Filter in particular and we find issues this way. |
What do you mean? |
|
Just following along as you and Ryan discuss the issue. I didn’t have a particular comment that was constructive but may have offered an Aside, if such things had a home. 🙂 |
Supersedes #6041 - thanks @blueyed!