Move guardian imports out of compat #6054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
approved these changes
Jun 23, 2018
rest_framework/compat.py
Outdated
| except ImportError: | ||
| pass | ||
| # django-guardian is optional and only imported if in INSTALLED_APPS. | ||
| def is_guardian_installed(): |
There was a problem hiding this comment.
Maybe use a __doc__ comment here?
auvipy
approved these changes
Jun 28, 2018
carltongibson
approved these changes
Jul 6, 2018
a52a646 to
304befb
Compare
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #6038. The check now just ensures
guardianis present in theINSTALLED_APPS, without attempting an import. Since this check is called during runtime by the framework, we won't trigger a "Django is not configured" error.