Skip to content

Add a 'request_forms' block to base.html #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

ababic
Copy link
Contributor

@ababic ababic commented Nov 28, 2018

Supersedes: #6337

Resolves: #6339

On advice from @tomchristie, I've deliberately left indentation as it is.

I've also simplified things by only adding a single block instead of three. While not quite as helpful for users wanting to override other bits within the content block, it's a smaller change with less of a maintenance commitment.

@rpkilby
Copy link
Member

rpkilby commented Nov 28, 2018

Thanks for the updated PR. As @tomchristie said, will need to think on it.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this stands it's seems OK to me.

@tomchristie
Copy link
Member

Yup, looks good.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for the input.

Welcome aboard @ababic! 💃

@carltongibson carltongibson merged commit 87ade87 into encode:master Jan 24, 2019
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants