Explicitly raise exc in 'raise_uncaught_exception' #6435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
approved these changes
Feb 2, 2019
|
A sanity check that we might? want to try. Raise an exception in a view and double check if the traceback ends up the same before and after this change. (Or we could just hit go, which I’m probably okay with) |
|
So I just checked, and the change is a very slight improvement. A bare Here was a quick test that I added to class TestTestTestTest(TestCase):
def setUp(self):
self.view = ErrorView.as_view()
def test_get_exception_handler(self):
request = factory.get('/', content_type='application/json')
response = self.view(request)
print(response.status_code)
print(response.data)Traceback w/ bare raise: tests/test_views.py:153: in test_get_exception_handler
response = self.view(request)
.tox/venvs/py37-django21/lib/python3.7/site-packages/django/views/decorators/csrf.py:54: in wrapped_view
return view_func(*args, **kwargs)
.tox/venvs/py37-django21/lib/python3.7/site-packages/django/views/generic/base.py:68: in view
return self.dispatch(request, *args, **kwargs)
rest_framework/views.py:495: in dispatch
response = self.handle_exception(exc)
rest_framework/views.py:455: in handle_exception
self.raise_uncaught_exception(exc)
rest_framework/views.py:492: in dispatch
response = handler(request, *args, **kwargs)
tests/test_views.py:45: in get
raise Exception
E ExceptionException with explicit raise: tests/test_views.py:153: in test_get_exception_handler
response = self.view(request)
.tox/venvs/py37-django21/lib/python3.7/site-packages/django/views/decorators/csrf.py:54: in wrapped_view
return view_func(*args, **kwargs)
.tox/venvs/py37-django21/lib/python3.7/site-packages/django/views/generic/base.py:68: in view
return self.dispatch(request, *args, **kwargs)
rest_framework/views.py:495: in dispatch
response = self.handle_exception(exc)
rest_framework/views.py:455: in handle_exception
self.raise_uncaught_exception(exc)
rest_framework/views.py:466: in raise_uncaught_exception
raise exc
rest_framework/views.py:492: in dispatch
response = handler(request, *args, **kwargs)
tests/test_views.py:45: in get
raise Exception
E ExceptionI'd say the more complete traceback makes more sense, in addition to the points I made in #6404 (comment). I don't think there's any specific test to be added though? We'd just be testing Python's exception handling? |
|
Brill. Yes. |
rpkilby
added a commit
that referenced
this pull request
May 10, 2019
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6404
My greatest contribution yet 😄
Although, knowing my luck, this will break something.