-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Make Markdown 2.6 the minimum compatible version #6576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Related to #6412. For 3.10 we may just want to bump the required markdown version. (?) |
Agreed - markdown 2.2 dates to 2012, and 2.5 to 2014. I don't think we need to support versions that outdated. |
Ok satisfied the linter, happy if you want to stop supporting old versions otherwise feel free to approve and merge my commit to avoid the warning |
I had a look at requiring markdown>2.6 but markdown is only an optional extra not a requirement so you can't add a requirements markdown>=2.6 that I can see, the option would be to alter the documentation to hint markdown >= 2.6 was required and perhaps add a warning for lower markdown versions or raise an exception or simply refuse processing markdown if the library is too low. None seem great options, I think the current PR might be the lesser evil. |
I made an alternative at https://github.com/timgates42/django-rest-framework/commit/64b311a8163b66a4527d2f02b8efb5adec30b745 which adjusts the documentation and drops support but not sure I like it |
@timgates42 let's go with https://github.com/timgates42/django-rest-framework/commit/64b311a8163b66a4527d2f02b8efb5adec30b745, although I would remove the version change from |
Thanks @rpkilby adjusted accordingly. |
Thanks @timgates42! |
Your welcome @rpkilby thanks for helping me get this in and get rid of the deprecation warning. |
🥂 |
Uh oh!
There was an error while loading. Please reload this page.