Replaced 'TODO' hardcoded version info by a parameter with default '0… #6899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, taking this on is good but why a hard coded value? In a way, I’d rather the TODO. (At least then I override get_schema to provide a sensible value...) The init parameter is maybe right. That would need documentation. |
|
Well, 'version' is mandatory in openapi specification. I have just chosen the 1st semantic minor version like other framework does: https://github.com/tiangolo/fastapi/blob/dcc1e1bcf823927817d8c133962bdb7a29e3d797/fastapi/applications.py#L32 |
- added version to high level API get_schema_view - updated the documentation
carltongibson
approved these changes
Sep 3, 2019
brianhelba
added a commit
to brianhelba/djangorestframework-stubs
that referenced
this pull request
Dec 5, 2019
brianhelba
added a commit
to brianhelba/djangorestframework-stubs
that referenced
this pull request
Dec 6, 2019
mkurnikov
pushed a commit
to typeddjango/djangorestframework-stubs
that referenced
this pull request
Dec 7, 2019
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openapi SchemaGenerator was setting 'TODO' as version info. Replaced by a parameter with default value '0.1.0'