DRF 3.11 : added django 3.0 & removed vesion below 2.1 from martrix #6942
Conversation
|
how to fix the Django six import error? |
There was a problem hiding this comment.
Hi @auvipy.
I'm happy if you want to add 3.0a1 as an allowed failure.
Please don't drop other versions. We'll do that when they're EOL (or later).
six... We dropped Python 2, and removed six. So is it one of the dependencies? (During the preview period we'd expect compat issues, hence an allowed failure.)
Please revert the other changes, to address in other PRs.
There's no need or reason to change everything to use path. url, or re_path is fine — it's not going anywhere. Note that the import you'd need is from django.urls. (As I say, not in this PR in any case please.)
(It's worth running the tests locally and making sure they pass before push to GitHub.)
Thanks.
|
OK, I will come with separate PR as you suggested. |
|
Thanks @auvipy! |
| @@ -1,11 +1,10 @@ | |||
| import unittest | |||
| from collections import namedtuple | |||
|
|
|||
| from django.conf.urls import include, url | |||
| from django.urls import include, path, re_path, include, Resolver404 | |||
|
Closing in favor of #7058 |
|
i thought the path/re_path update would be useful ater django 1.11 support drop. |
|
Indeed - hoping to take a look at that. |
|
I you want I can contribute that part :) |
No description provided.