Skip to content

Bump CI to Python 3.8 #7008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 22, 2019
Merged

Bump CI to Python 3.8 #7008

merged 5 commits into from
Oct 22, 2019

Conversation

Djailla
Copy link
Contributor

@Djailla Djailla commented Oct 21, 2019

Description

Python 3.8 is available, add tests in tox and travis

rpkilby
rpkilby suggested changes Oct 21, 2019
View reviewed changes
Djailla
Djailla commented Oct 22, 2019
View reviewed changes
Copy link
Contributor Author

@Djailla Djailla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Djailla Djailla requested a review from rpkilby October 22, 2019 07:02
Djailla
Djailla commented Oct 22, 2019
View reviewed changes
Copy link
Contributor Author

@Djailla Djailla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rpkilby
Update codestyle requirements
90ad36c 
Fixes a Python 3.8 compat issue with flake8
@rpkilby
Copy link
Member

rpkilby commented Oct 22, 2019 •
edited
Loading

oof. This is more annoying than expected.

  • pyflakes isn't compatible with Python 3.8, so upgraded flake8
  • upgrading flake8 also requires upgrading pycodestyle
  • pycodestyle changed its behavior to prefer line breaks before a binary operator
    https://lintlyci.github.io/Flake8Rules/rules/W504.html
    Actually, the issue is that we override the flake8 ignore list to just E501, so the rules now contain the contradictory W503/W504 warnings. The fix is to choose one.
  • incur the wrath of the linter

I'll address the style changes in a separate PR.

@rpkilby
Drop basepython from tox config
4d81958 
Using basepython should no longer be necessary. We just need some 
version of Python 3 to run the env, and since the project is now 
Python 3-only, there is no reason to require this. Note that it was
necessary previously when DRF was Python 2/3 compatible.
@rpkilby
Copy link
Member

rpkilby commented Oct 22, 2019

Linter issues were fixed in #7010.

@Djailla
Copy link
Contributor Author

Djailla commented Oct 22, 2019

@rpkilby Hello Ryan, what should I do next ? Wait for other reviews ?

@rpkilby rpkilby changed the title Bump to python 3.8 Bump CI to Python 3.8 Oct 22, 2019
@rpkilby
Copy link
Member

rpkilby commented Oct 22, 2019 •
edited
Loading

Nope, was just waiting for CI to finish. Thanks!

@rpkilby rpkilby merged commit 64f567a into encode:master Oct 22, 2019
@Djailla Djailla deleted the py38 branch October 22, 2019 22:50
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@Djailla
Bump CI to Python 3.8 (encode#7008)
2dd6271
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@Djailla @sigvef
Bump CI to Python 3.8 (encode#7008)
56646fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xordoquy xordoquy xordoquy left review comments

@rpkilby rpkilby rpkilby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Djailla @rpkilby @xordoquy