Skip to content

Fix override func style and regular usage #7050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2019
Merged

Fix override func style and regular usage #7050

merged 3 commits into from
Nov 18, 2019

Conversation

chrisguox
Copy link
Contributor

  • add space and rm redundant parentheses
  • replace str class with super
  • replace cls with self in class method (but I see someone fixed it)

@tomchristie
Copy link
Member

Thanks!

@tomchristie tomchristie merged commit cad1b08 into encode:master Nov 18, 2019
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@chrisguox
Fix override func style and regular usage (encode#7050)
8e61f6a 
* style: add space and rm redundant parentheses

* refactor: use super to replace inherit class

* Prefer explicit tuple syntax
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@chrisguox @sigvef
Fix override func style and regular usage (encode#7050)
9b608c6 
* style: add space and rm redundant parentheses

* refactor: use super to replace inherit class

* Prefer explicit tuple syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisguox @tomchristie @rpkilby