Break long headers on the browsable API #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Breaks headers longer than 160 characters (~page length) | ||
| when possible (are comma separated) | ||
| """ | ||
| if len(header) > 160: |
There was a problem hiding this comment.
Maybe add and ',' in header?
|
Seems good to me, could you also add a line to the release notes. |
|
Good catch Tom! thanks! |
tomchristie
added a commit
that referenced
this pull request
Apr 4, 2013
Break long headers on the browsable API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Link header, when used, usually gets very long and its ugly to have it rendered in a single line on the browsable API.
I've added a simple templatetag that breaks long headers in multiple lines, when possible (comma separated).
you can see its usefulness in here:
http://devel.controller.confine-project.eu/api/