Make set_value a method within `Serializer` #8001

tienne-B · 2021-05-20T16:18:58Z

As an alternative to #7671, let the method be overridden if needed.

As the function is only used for serializers, it has a better place in the Serializer class than standalone in the fields file.

As an alternative to encode#7671, let the method be overridden if needed. As the function is only used for serializers, it has a better place in the Serializer class.

stale · 2022-04-18T10:57:11Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tienne-B · 2022-04-18T13:13:29Z

I do think this PR is still pertinent as it would make it so I wouldn't have to override an unrelated method as I currently do.

stale · 2022-06-18T20:42:32Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tienne-B · 2022-06-18T21:47:13Z

I repeat.

stale · 2022-10-19T06:17:08Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tomchristie · 2022-10-19T08:29:23Z

Okay...

I'm open to considering this. We're pretty much not adding public API to REST framework anymore, but let's take a look.

I'd suggest start off by changing it to not be a staticmethod. Agreed that it functionally is, but we don't use that much through REST framework, so let's stick with consistency.

That edit should also bump the test cases to run against this pull request.

auvipy · 2022-12-01T12:24:20Z

That edit should also bump the test cases to run against this pull request.

does that mean some additional tests should be added or tests should be adjusted as well?

These tests follow the examples given in the method.

# Conflicts: # tests/test_serializer.py

tienne-B · 2023-02-28T01:47:20Z

@auvipy There were no tests specifically for set_value() so I've added a couple cases from the method doc.

auvipy · 2023-02-28T09:31:46Z

rest_framework/serializers.py

@@ -346,6 +346,26 @@ class Serializer(BaseSerializer, metaclass=SerializerMetaclass):
        'invalid': _('Invalid data. Expected a dictionary, but got {datatype}.')
    }

+    def set_value(self, dictionary, keys, value):


do we need any documentation update // adjustments for the new changes?

I wouldn't think so, as the change is really just internal and does not affect how set_value() works. Would you want me to document the changes somewhere?

stale · 2023-05-21T21:10:48Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tienne-B · 2023-05-21T21:16:32Z

I'm still interested in this, and waiting for a reply from @auvipy.

auvipy · 2023-05-24T12:02:41Z

I'm still interested in this, and waiting for a reply from @auvipy.

can you edit the PR headline as per the suggested change by Tom?

tienne-B · 2023-05-24T13:19:49Z

can you edit the PR headline as per the suggested change by Tom?

Done :)

* Make set_value a static method for Serializers As an alternative to encode#7671, let the method be overridden if needed. As the function is only used for serializers, it has a better place in the Serializer class. * Set `set_value` as an object (non-static) method * Add tests for set_value() These tests follow the examples given in the method.

* fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer * fix formatting issues for list serializer validation fix * fix imports sorting for list serializer tests * remove django 2.2 from docs index (#8982) * Declared Django 4.2 support in README.md (#8985) * Fix Links in Documentation to Django `reverse` and `reverse_lazy` (#8986) * Fix Django Docs url in reverse.md Django URLs of the documentation of `reverse` and `reverse_lazy` were wrong. * Update reverse.md * fix URLPathVersioning reverse fallback (#7247) * fix URLPathVersioning reverse fallback * add test for URLPathVersioning reverse fallback * Update tests/test_versioning.py --------- Co-authored-by: Jorn van Wier <jorn.van.wier@thunderbyte.ai> Co-authored-by: Asif Saif Uddin <auvipy@gmail.com> * Make set_value a method within `Serializer` (#8001) * Make set_value a static method for Serializers As an alternative to #7671, let the method be overridden if needed. As the function is only used for serializers, it has a better place in the Serializer class. * Set `set_value` as an object (non-static) method * Add tests for set_value() These tests follow the examples given in the method. * fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer * Make set_value a method within `Serializer` (#8001) * Make set_value a static method for Serializers As an alternative to #7671, let the method be overridden if needed. As the function is only used for serializers, it has a better place in the Serializer class. * Set `set_value` as an object (non-static) method * Add tests for set_value() These tests follow the examples given in the method. * fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer * fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer * fix formatting issues for list serializer validation fix * fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer * fix formatting issues for list serializer validation fix * fix linting * Update rest_framework/serializers.py Co-authored-by: Sergei Shishov <sshishov@users.noreply.github.com> * Update rest_framework/serializers.py Co-authored-by: Sergei Shishov <sshishov@users.noreply.github.com> * fix: instance variable in list serializer, remove commented code --------- Co-authored-by: Mathieu Dupuy <deronnax@gmail.com> Co-authored-by: Mehraz Hossain Rumman <59512321+MehrazRumman@users.noreply.github.com> Co-authored-by: Dominik Bruhn <dominik@dbruhn.de> Co-authored-by: jornvanwier <mail@jornvanwier.com> Co-authored-by: Jorn van Wier <jorn.van.wier@thunderbyte.ai> Co-authored-by: Asif Saif Uddin <auvipy@gmail.com> Co-authored-by: Étienne Beaulé <beauleetienne0@gmail.com> Co-authored-by: Sergei Shishov <sshishov@users.noreply.github.com>

Make set_value a static method for Serializers

17fb350

As an alternative to encode#7671, let the method be overridden if needed. As the function is only used for serializers, it has a better place in the Serializer class.

tienne-B mentioned this pull request Aug 22, 2021

Allow editing of motions within Round endpoint TabbycatDebate/tabbycat#1858

Open

blockchainGuru1018 approved these changes Nov 6, 2021

View reviewed changes

stale bot added the stale label Apr 18, 2022

stale bot removed the stale label Apr 18, 2022

stale bot added the stale label Jun 18, 2022

stale bot removed the stale label Jun 18, 2022

stale bot added the stale label Oct 19, 2022

tomchristie removed the stale label Oct 19, 2022

Set set_value as an object (non-static) method

dcbdb71

auvipy closed this Dec 1, 2022

auvipy reopened this Dec 1, 2022

auvipy added the Cleanup label Dec 1, 2022

tienne-B added 2 commits February 27, 2023 21:45

Add tests for set_value()

a487f85

These tests follow the examples given in the method.

Merge remote-tracking branch 'upstream/master' into set_value_static

0455e27

# Conflicts: # tests/test_serializer.py

tienne-B force-pushed the set_value_static branch from 0da32d0 to 0455e27 Compare February 28, 2023 01:46

auvipy suggested changes Feb 28, 2023

View reviewed changes

tienne-B requested a review from auvipy February 28, 2023 12:13

stale bot added the stale label May 21, 2023

stale bot removed the stale label May 21, 2023

auvipy approved these changes May 24, 2023

View reviewed changes

tienne-B changed the title ~~Make set_value a static method for Serializers~~ Make set_value a method within Serializer May 24, 2023

auvipy added this to the 3.15 milestone May 24, 2023

auvipy merged commit d252d22 into encode:master May 24, 2023

tienne-B deleted the set_value_static branch May 24, 2023 14:07

JaeHyuckSa mentioned this pull request Apr 14, 2024

[3.15] Move fields.set_value to Serializer.set_value typeddjango/djangorestframework-stubs#576

Merged

joeyorlando mentioned this pull request Aug 9, 2024

Bump djangorestframework from 3.14.0 to 3.15.2 in /engine grafana/oncall#4593

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Make set_value a method within `Serializer` #8001

Make set_value a method within `Serializer` #8001

Uh oh!

tienne-B commented May 20, 2021

Uh oh!

stale bot commented Apr 18, 2022

Uh oh!

tienne-B commented Apr 18, 2022

Uh oh!

stale bot commented Jun 18, 2022

Uh oh!

tienne-B commented Jun 18, 2022

Uh oh!

stale bot commented Oct 19, 2022

Uh oh!

tomchristie commented Oct 19, 2022

Uh oh!

auvipy commented Dec 1, 2022

Uh oh!

tienne-B commented Feb 28, 2023

Uh oh!

auvipy Feb 28, 2023

Uh oh!

tienne-B Feb 28, 2023

Uh oh!

stale bot commented May 21, 2023

Uh oh!

tienne-B commented May 21, 2023

Uh oh!

auvipy commented May 24, 2023

Uh oh!

tienne-B commented May 24, 2023

Uh oh!

Uh oh!

Uh oh!

Make set_value a method within Serializer #8001

Make set_value a method within Serializer #8001

Uh oh!

Conversation

tienne-B commented May 20, 2021

Uh oh!

stale bot commented Apr 18, 2022

Uh oh!

tienne-B commented Apr 18, 2022

Uh oh!

stale bot commented Jun 18, 2022

Uh oh!

tienne-B commented Jun 18, 2022

Uh oh!

stale bot commented Oct 19, 2022

Uh oh!

tomchristie commented Oct 19, 2022

Uh oh!

auvipy commented Dec 1, 2022

Uh oh!

tienne-B commented Feb 28, 2023

Uh oh!

auvipy Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

tienne-B Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

stale bot commented May 21, 2023

Uh oh!

tienne-B commented May 21, 2023

Uh oh!

auvipy commented May 24, 2023

Uh oh!

tienne-B commented May 24, 2023

Uh oh!

Uh oh!

Make set_value a method within `Serializer` #8001

Make set_value a method within `Serializer` #8001