Use ZoneInfo as primary source of timezone data #8924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for being the go-to guy for zoneinfo migration in several packages I maintain//co-maintain :D |
auvipy
suggested changes
Apr 8, 2023
|
could not we remove the requirement on pytz? |
|
Hey, is there any progress on this pull request and the underlying issue? I would like to get rid of pytz. Thanks! |
|
it's has been done months ago #8984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing guidelines.
Description
This PRs switches over to
ZoneInfoas the primary source of timezone data in DRF. This PR accomplishes several things:pytz.pytzfunctionality over toZoneInfo.ZoneInfotimezones. This is because unlikepytz, error checking has to be done more or less manually in able to determine ambiguous and imaginary timezones (see this doc on migrating toZoneInfo). We previously had exception handling inDateTimeFieldforpytzerrors, but I added manually checking that will coverZoneInfotimezones.Django will provide us
ZoneInfoinstances as long asUSE_DEPRECATED_PYTZis not enabledFixes #8577