added jQuery 3.7.1 support & dropped previous version #9094
Conversation
|
Hey thanks for your awesome PR. I have a question. Why is jQuery version 3.5.1 present in this repository? Since we are shipping jQuery 3.7.1 don't you think it's better to remove old version ? Thanks :D |
|
II actually removed that old version in this PR. I removed 2 old version of jquery in this PR ;) |
|
Makes sense but it was weird.. Anyways thanks for the PR |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
It was not deleted initially by mistake! but that was not shipped in PyPI yet :) so we are safe on that. |
|
I want some one to verify that this is not uploading anything malicious. |
There was a problem hiding this comment.
Hi @auvipy,
this is removing 3.6.4 and simply renaming 3.5.1 to 3.7.1. The PR still contains the old version, as the blob is not changing.
I don't think this is what you intended here. I'll be happy to confirm the hashes once updated.
|
Ops! how could I miss that! |
|
I'm not sure if the CI failure due to my push or its github issue? I initially forgot to save the codes and committed without saving |
There was a problem hiding this comment.
➜ ~ wget -q -O- https://cdn.jsdelivr.net/npm/jquery@3.7.1/dist/jquery.min.js | shasum
ee48592d1fff952fcf06ce0b666ed4785493afdc -
➜ ~ wget -q -O- https://raw.githubusercontent.com/encode/django-rest-framework/088bfdc0bb4d7170c2a292e14ecd2e768e4ddbf4/rest_framework/static/rest_framework/js/jquery-3.7.1.min.js | shasum
ee48592d1fff952fcf06ce0b666ed4785493afdc -
can confirm this is indeed the unmodified upstream build, i.e. the hashes match.
regarding the github action, I think the github action just bailed, which happens sometimes. have you tried rerunning it again manually?
|
I restarted the build |
|
This is what I got |
|
related PR for further investigating the issue #9097 |
|
the GHA seems to be working now |
|
thanks for taking your time to carefully review this folks! |
it is a maintenance release of jquery.